-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project
attribute to workspaces block
#257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the descriptions as mentioned in-line.
Side note:
We will also need to regenerate the versions here to "expose" it
terraform-schema/schema/versions_gen.go
Lines 9 to 13 in bdb076b
OldestAvailableVersion = version.Must(version.NewVersion("0.12.0")) | |
LatestAvailableVersion = version.Must(version.NewVersion("1.5.0")) | |
terraformVersions = version.Collection{ | |
version.Must(version.NewVersion("1.5.0")), |
And on a related note, we probably shouldn't be setting beta versions as latest when generating the file, meaning that we should be able to provide schema relevant to pre-releases such as 1.6.0-beta3
but only if the configuration explicitly opts into it or the user has installed that version, otherwise we should assume latest stable version. I'm happy to file this as a separate issue or raise a PR unless you plan to do it (obviously not part of this PR either way).
I added a TODO for later this week to regenerate the versions :) |
Co-authored-by: Radek Simko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #206
Example UX